Support custom tokens on chains that re-use chain IDs of well known chains

[kaimeinke]

User story:
As a user of frame I would like to import my custom tokens to have a correct overview over my balances.

Example:
Currently I am unable to add the custom token using the "Add Token" feature.

Network configuration is
Network name: GEN-X
New RPC URL: https://rpc.genx.minimal-gaia-x.eu/
Chain ID: 100
Currency Symbol: GX
Block Explorer URL: https://explorer.genx.minimal-gaia-x.eu/
Token Name & Address: "Ocean": "0x0995527d3473b3A98C471f1ED8787ACD77fBF009"

See: https://explorer.genx.minimal-gaia-x.eu/token/0x0995527d3473b3A98C471f1ED8787ACD77fBF009/token-transfers

Reproduction:

I use the "Add Token" function with the correct values.

After hitting "Add Token" the custom token does not appear in the overview.

Question:
How can I fix this and make the custom token appear in my balance?

[goosewobbler]

@kaimeinke This works for me on our latest Canary version, which will replace the beta.22 version of Frame soon when it moves to production. However in order to add the GEN-X chain I had to remove Gnosis, which uses the same chain ID.

[kaimeinke]

Thank you @goosewobbler , I am using https://github.com/floating/frame/releases/tag/v0.5.0-beta.22 and I am not able to add the custom token. Where could I find the latest version to try the update?

[goosewobbler]

https://github.com/frame-labs/frame-canary/releases

Please bear in mind that Canary may not be updated for some time once the release is completed so it will be better for you to switch back to using production (which will auto-update) after the release.

[kaimeinke]

Thanks a lot, I will report back after testing.

[kaimeinke]

Feedback after the initial testing. Thank you for the help @goosewobbler.

1. I am able to add the token. Autodiscovery works well.

2. I am unable to see the Token in the Balances overview after that.

It is not in the mainbar, which is most likely intended.

So, how can I enforce tokens to become visible because "as a user I need to have an overview of my portfolio"?

[goosewobbler]

@kaimeinke After adding, the token should now be displayed if you have a non-zero balance of it. If this isn't happening and you have a public address with some amount of the token I can check why this is happening through a watch account

[kaimeinke]

Thank you @goosewobbler

Currently, I only see the token if I open the token menu. At least that seems stable, but no amount is displayed.

You could use this address for a watch account 0x28080F654eED6CC00e8b16F4841E92CD0c2C0778, it certainly has a balance: https://explorer.genx.minimal-gaia-x.eu/address/0x28080F654eED6CC00e8b16F4841E92CD0c2C0778/tokens#address-tabs

[goosewobbler]

@kaimeinke This does appear to be a bug, custom tokens appear to be working fine on ETH mainnet but on GEN-X there is definitely something wrong. We are looking at it as part of our final sprint before the omnichain release.

[mholtzman]

@kaimeinke the issue here is that we use multicall contracts on every chain that supports them. since you're re-using chain ID 100, we try to call the multicall contract for Gnosis chain and this causes an error. for now, we won't be able to support custom tokens on chains that re-use chain IDs for other well known chains, though this is something we'll add to our backlog and revisit in the future

[goosewobbler]

I'm going to convert this to a discussion since we have established that it's more of a resiliency enhancement request than a bug. In an ideal world, chain IDs are unique and there is nothing wrong with Frame assuming that they are, but it would be nice if the edge case where a chain ID is re-used is handled more gracefully.

[kaimeinke]

Good idea, but you know how the space works and the assumption of a chainID being unique will be tested more than once, especially when it comes to early projects, forks, etc. Graceful handling would be very good.