chore(deps): update xo/dburl to v0.20.0 #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
- Coverage 70.87% 70.85% -0.03%
==========================================
Files 81 82 +1
Lines 8168 8193 +25
==========================================
+ Hits 5789 5805 +16
- Misses 2033 2042 +9
Partials 346 346 ☔ View full report in Codecov by Sentry. |
markphelps
approved these changes
Dec 13, 2023
markphelps
added a commit
that referenced
this pull request
Dec 17, 2023
…it/v5-5.11.0 * main: (31 commits) fix: resolved issues with go-git 5.11.0 (#2543) chore: Devenv (#2542) refactor(storage/fs): adjust the declarative storage abstractions (#2540) chore(readme): update readme with client-side eval info (#2539) chore(deps): bump cuelang.org/go from 0.6.0 to 0.7.0 (#2523) refactor: use rpc/flipt.Now everywhere instead of timestamppb.Now feat(rpc/flipt): add Now timestamp with microsecond precision function fix(mysql): increase timestamp precision from seconds to microseconds fix(build): create new db instance per api IT fix(cfg): default config outputs first INFO log regardless of FLIPT_LOG_LEVEL (#2536) feat(ui): show time/date format on settings/preferences page (#2537) fix(mod): update dagger in correct go.mod (build) chore(github): update DAGGER_VERSION to 0.9.4 chore: cleanup go work sum chore(build): update dagger to v0.9.4 fix(build/testing): use correct db url environment variable test: move database coverage into integration tests chore(deps): update xo/dburl to v0.20.0 (#2533) chore: update readme chore: update README ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2526
This updates xo/dburl to the latest version. There were issues with the last version, which we discussed in the xo/dburl repository. This newer version has a package level boolean which allows us to get the old behaviour we depended upon.
See: xo/dburl#35 (comment)
Update: Using the suggested
dburl.ResolveSchemeType = falsejust made things worse.This caused all the flavours of
file:/prefixed DB URLs to return "unknown extension".Instead, I took the other approach mentioned, which was to override
dburl.Stat.The version we supply to dburl now actually just sinks not found errors (this is what causes dburl to go on a hunt for the existence of parent directories). By returning a nil error and a fs.FileInfo that is neither a directory, nor a socket, it instead forces dburl to attempt to move on an open the file path (via OpenFile this time). If the file exists, it checks the files header bytes for sqlite, if it doesn't exist, it uses the files extension.