Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants keys should be unique per flag, not globally #87

Closed
twgraham opened this issue Jun 2, 2019 · 3 comments · Fixed by #88
Closed

Variants keys should be unique per flag, not globally #87

twgraham opened this issue Jun 2, 2019 · 3 comments · Fixed by #88

Comments

@twgraham
Copy link

twgraham commented Jun 2, 2019

When trying to create a variant for a flag where the key is default, I'm getting an error suggesting that the key needs to be unique, despite the no existing variants for the flag. I do have a variant with the key default on another flag though.

I would expect that the keys for variants should be unique per flag rather than globally, since there is no way that these variants can be used across flags.

@markphelps
Copy link
Collaborator

Great point and thank you for the issue! Will work on this ASAP.

@markphelps markphelps added this to the 1.0.0 milestone Jun 2, 2019
@markphelps markphelps mentioned this issue Jun 4, 2019
3 tasks
@markphelps
Copy link
Collaborator

@twgraham this has been merged, but am planning to make some changes on how migrations are run to make them safer before cutting a new release. should have that done and a new release cut by this weekend

@twgraham
Copy link
Author

twgraham commented Jun 6, 2019

Woohoo! Thanks @markphelps 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants