Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow empty rules to be created in UI #758

Closed
markphelps opened this issue Mar 20, 2022 · 0 comments · Fixed by #759
Closed

Don't allow empty rules to be created in UI #758

markphelps opened this issue Mar 20, 2022 · 0 comments · Fixed by #759
Assignees
@markphelps

Comments

@markphelps
Copy link
Collaborator

markphelps commented Mar 20, 2022 •
edited
Loading

Re: #367

Going with option 1 for the UI.

The original issue is renamed to mention that it will be a breaking change to fix for the API

Thinking about this some, this would likely be a breaking change since it currently evaluates today.

A couple of options:

1. Dont make this change now and add it to v2 where we can make breaking changes
2. Only prevent creating empty rules in the UI, we could still allow empty rules to be created via the API.

I'm leaning towards 1 but would like more thoughts

Originally posted by @markphelps in #367 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markphelps markphelps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow rule create with no distributions; update imports flipt-io/flipt
1 participant
@markphelps