Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting the intersection of multiple segments in a single rule #732

Closed
jalaziz opened this issue Mar 9, 2022 · 2 comments
Closed

Targeting the intersection of multiple segments in a single rule #732

jalaziz opened this issue Mar 9, 2022 · 2 comments
Assignees

Comments

@jalaziz
Copy link
Contributor

jalaziz commented Mar 9, 2022

Is your feature request related to a problem? Please describe.

We've started to rollout flipt and mostly love it. However, we have encountered a few limitations in the way segments and rules are defined. In particular, the lack of full boolean logic makes certain configurations quite verbose. For example, it's difficult to create a target that matches "all dev environments and all API users" where "all dev environments" is defined as "staging, nightly, etc".

Describe the solution you'd like

We'd like to see the ability to define targeting rules as a boolean combination of segments. While we can technically achieve "OR" combinations by defining multiple rules, "AND" combinations are much harder to accomplish. In order to achieve this today, we would have to create segments for every combination we would like to target; however, since segment constraints don't support combining logical operators, this is also limited.

This is somewhat related to #318, but also more general and focused on targeting rules.

Additional context

We'd be happy to help contribute this, but I wanted to start the discussion to ensure the request makes sense for the broader project.

@markphelps
Copy link
Collaborator

@jalaziz Thanks for the issue. I really like this idea. I'm trying to visualize how this could best be displayed to the user in the UI.

One idea is to simply allow you to specify multiple segments in the rule creation, and the UI would inform the user that this is an ANDing of the two segments.

Another potential solution that comes to mind is to support something like 'rule groups' where you can AND two rules together, but that might get complicated when it comes to distributions.

I would definitely welcome contributions on this, even if its just a mockup of how you would expect the user interaction to work from a UI and API perspective.

@stale
Copy link

stale bot commented Oct 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants