Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test to check that expected migration versions are correct #706

Closed
markphelps opened this issue Feb 14, 2022 · 0 comments · Fixed by #712
Closed

Create test to check that expected migration versions are correct #706

markphelps opened this issue Feb 14, 2022 · 0 comments · Fixed by #712

Comments

@markphelps
Copy link
Collaborator

Re: #700

1.6.0 release was unsuccessful because we forgot to bump the expected db migration versions here: https://github.com/markphelps/flipt/pull/700/files#diff-90c8434c840e0b93eed0f28e4d501b0f48b3ac122c555178a6e963dc7d8ff311L17-L21 when new migrations were added in #685

We should automate this check, perhaps just making it a regular go test in the migrator package that will fail if there are new migrations added that have not been reflected in the above map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant