Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database credentials are visible in log #319

Closed
giddel opened this issue Jul 16, 2020 · 1 comment · Fixed by #320
Closed

database credentials are visible in log #319

giddel opened this issue Jul 16, 2020 · 1 comment · Fixed by #320
Labels

Comments

@giddel
Copy link
Contributor

giddel commented Jul 16, 2020

Description
The database connection is configured by a connection string containing the credentials.
This connection string is complete printed to the log at startup time.

time="2020-07-16T08:23:13Z" level=debug msg="connecting to database: mysql://XXXX:YYYY@ZZZZ:3306/flipt" server=grpc
time="2020-07-16T08:23:13Z" level=debug msg="migrations up to date" migrator=mysql
time="2020-07-16T08:23:13Z" level=debug msg="starting grpc server" server=grpc store=mysql
time="2020-07-16T08:23:14Z" level=debug msg="starting http server" server=http

Version
Version: 0.16.0

Expected behavior
No credentials are visible in the logs!

@markphelps
Copy link
Collaborator

@giddel thanks for the issue! I pushed a backported fix to https://github.com/markphelps/flipt/releases/tag/v0.16.1 since I see you are on v0.16.0

I'm also forward fixing on https://github.com/markphelps/flipt/releases/tag/v0.17.1 / latest if you want to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants