Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context parse error should not return 500 response #1046

Closed
markphelps opened this issue Sep 30, 2022 · 0 comments · Fixed by #1047
Closed

Context parse error should not return 500 response #1046

markphelps opened this issue Sep 30, 2022 · 0 comments · Fixed by #1047
Assignees
Labels

Comments

@markphelps
Copy link
Collaborator

Describe the Bug

When testing via https://try.flipt.io, I came across an issue when trying to evaluate a context that contained a field that was trying to be parsed as a boolean x, which obviously cant be parsed as a bool. This was resulting in a 500 response being return from the API (REST).

The evaluation console also showed an empty response, instead of displaying the actual error.

Version Info

Run flipt --version and paste the output here:

To Reproduce

https://github.com/flipt-io/flipt/releases/tag/v1.11.0

Expected Behavior

  • A 4xx response or similar, the server should not return a 500
  • In the UI, the evaluation console should display the error (and highlight the window in red) instead of an empty response (in green)

Additional Context

Add any other context about the problem here.

Examples:

  • OS
  • Config file used
  • Database used (SQLite, MySQL, or Postgres)
  • Screenshots
  • Exported data from the database

Screenshots

Screen Shot 2022-09-29 at 9 17 03 PM

Screen Shot 2022-09-29 at 9 17 23 PM

Screen Shot 2022-09-29 at 9 17 10 PM

Attach an Export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant