Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli nfc command does not work after NFC refactor #3276

Open
u0d7i opened this issue Dec 7, 2023 · 4 comments
Open

cli nfc command does not work after NFC refactor #3276

u0d7i opened this issue Dec 7, 2023 · 4 comments
Assignees
Labels
Feature Request New feature or user-story you wanna add to flipper NFC NFC-related

Comments

@u0d7i
Copy link

u0d7i commented Dec 7, 2023

Describe the bug.

After NFC refactor, cli "nfc" command shows empty sub-command list and does not work anymore:

+ device: /dev/ttyACM0
starting cli, Ctrl+C to terminate

              _.-------.._                    -,
          .-"```"--..,,_/ /`-,               -,  \ 
       .:"          /:/  /'\  \     ,_...,  `. |  |
      /       ,----/:/  /`\ _\~`_-"`     _;
     '      / /`"""'\ \ \.~`_-'      ,-"'/ 
    |      | |  0    | | .-'      ,/`  /
   |    ,..\ \     ,.-"`       ,/`    /
  ;    :    `/`""\`           ,/--==,/-----,
  |    `-...|        -.___-Z:_______J...---;
  :         `                           _-'
 _L_  _     ___  ___  ___  ___  ____--"`___  _     ___
| __|| |   |_ _|| _ \| _ \| __|| _ \   / __|| |   |_ _|
| _| | |__  | | |  _/|  _/| _| |   /  | (__ | |__  | |
|_|  |____||___||_|  |_|  |___||_|_\   \___||____||___|

Welcome to Flipper Zero Command Line Interface!
Read Manual https://docs.flipperzero.one

Firmware version: dev unknown (82baf1e9 built on 05-12-2023)

>: nfc
nfc
Usage:
nfc <cmd>
Cmd list:

>: 

Reproduction

  1. Connect to FZ serial port
  2. Execute 'nfc' command via cli

Target

7

Logs

No response

Anything else?

tested on latest devbuild ATM (latest releases and rc's have the same issues)

@Tomi2965
Copy link

Tomi2965 commented Dec 7, 2023

I can confirm - same here on latest versions. Same issue

@v0lp3
Copy link
Contributor

v0lp3 commented Dec 8, 2023

I don't think it is a bug, after that refactoring the only command available (if the debug flag is active) is "field"

@u0d7i
Copy link
Author

u0d7i commented Dec 8, 2023

I don't think it is a bug, after that refactoring the only command available (if the debug flag is active) is "field"

Before refactor it had:

Firmware version: 0.89.0 0.89.0 (5a58004b built on 16-08-2023)

>: nfc
nfc
Usage:
nfc <cmd>
Cmd list:
        detect   - detect nfc device
        emulate  - emulate predefined nfca card
        apdu     - Send APDU and print response 

>: 

And I was relying on apdu one. If this is official and final now, and it 's not going to be re-implemented, would be nice to have a clear statement from the development team on that. I've seen changes in official docs here: https://docs.flipper.net/development/cli , which only refers to: "nfc - NFC factory test app: controls field when the device is in Debug mode." now.

@gornekich
Copy link
Member

Hello @u0d7i . These commands were removed after refactoring indeed. I am planning to add some cli commands in next release

@gornekich gornekich self-assigned this Dec 11, 2023
@skotopes skotopes added Feature Request New feature or user-story you wanna add to flipper NFC NFC-related labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or user-story you wanna add to flipper NFC NFC-related
Projects
None yet
Development

No branches or pull requests

5 participants