-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flint.good can not be imported (python-flint 0.5) #102
Comments
Hi Tim, thanks for testing. Is this something that you were using in previous releases of python-flint? I have just tested that this works with 0.5.0: from flint.functions.showgood import good To make it importable at top-level it would need to be added here: python-flint/src/flint/__init__.py Line 27 in 9252d17
|
Hi Oscar, The import from flint.functions.showgood worked fine in my case as well :) |
Okay, so there are three problems here.
|
This is how the doctests can be run. They fail immediately: $ pytest --doctest-glob='*.rst' doc/source/
======================================== test session starts ========================================
platform linux -- Python 3.11.3, pytest-7.4.0, pluggy-1.2.0
rootdir: /home/oscar/current/active/python-flint
plugins: hypothesis-6.84.2, cov-4.1.0, split-0.8.1, timeout-2.1.0, doctestplus-1.0.0, xdist-3.3.1
collected 1 item
doc/source/general.rst F [100%]
============================================= FAILURES ==============================================
_______________________________________ [doctest] general.rst _______________________________________
039 dps = 15 # real/complex precision (in digits)
040 cap = 10 # power series precision
041 threads = 1 # max number of threads used internally
042
043 The user can mutate the properties directly, for example::
044
045 >>> ctx.pretty = False
046 >>> fmpq(3,2)
047 fmpq(3,2)
048 >>> ctx.pretty = True
Expected:
3/2
Got nothing
/home/oscar/current/active/python-flint/doc/source/general.rst:48: DocTestFailure
====================================== short test summary info ======================================
FAILED doc/source/general.rst::general.rst
========================================= 1 failed in 0.08s ========================================= No surprise there are the doctest is wrong (it shouldn't output anything): python-flint/doc/source/general.rst Lines 45 to 49 in 9252d17
|
Thanks for all the effort ! |
Thanks Tim. This should be fixed in the next release. |
Hi all,
thanks for the nice python package. I stumbled over a potential bug in the new 0.5 release.
I did install python flint 0.5 via
pip install python-flint
I can import and use any sub module/function except for flint.good.
Calling
from flint import good
or
from flint.functions import good
throw Import errors. Importing showgood however works fine.
Best,
Tim
The text was updated successfully, but these errors were encountered: