Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for ANSI escape sequences #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonis
Copy link

@simonis simonis commented Apr 17, 2020

This feature is currently enabled by default on Linux but can be switched on with -DisAnsiTTY=true on any platform that supports ANSI escape sequences.
If ANSI escapes are enabled, there will be no more scrolling at each new report output.

Also eliminated trailing whitespaec and tabs.

This feature is currently enabled by default on Linux but can be switched on with -DisAnsiTTY=true on any platform that supports ANSI escape sequences.
If ANSI escapes are enabled, there will be no more scrolling at each new report output.

Also eliminated trailing whitespaec and tabs.
@egahlin
Copy link
Member

egahlin commented Apr 20, 2020

Nice idea, but how does this work if you want to log something at the same time? Perhaps it is better to make it into an option, i.e.

$ java -javaagent:health-report.jar:scroll=false

private final static void start(String args) {
var options = parseAgentOptions(args);
scroll = Boolean.valueOf(options.getOrDefault("scroll", "true");
...

There is already support for parsing agent options in the file.

@simonis
Copy link
Author

simonis commented Apr 20, 2020

Sure, I can do that. Do you want it on or off by default?

@egahlin
Copy link
Member

egahlin commented Apr 23, 2020

I like it to scroll by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants