Required times property for subscribe event

[insertmike]

Why is the times property required? Assuming it is used to specify the number of times the eventHandler function should be called when a specified event occurs, why enforcing this?

Typescript complaining if not passed:

  scatter.subscribe<"select">("select", (event: EventMap["select"]) => {
     ...
  });

Error:

Expected 3 arguments, but got 2.ts(2554)
regl-scatterplot.esm.d.ts(73, 361): An argument for 'times' was not provided

In fact, where is this used, I can't find a reference for times in the repository, except at PubSubEvent definition. Is it retrieved somewhere dynamically from arg length?

regl-scatterplot/src/types.d.ts

Line 210 in 91aa396

times: number

[flekschas]

This is just a typing issue. The property is coming from https://github.com/flekschas/pub-sub and is not required. By default it's set to Infinity. I'll update the type in the next release, thanks for bringing this up.

[flekschas]

Just released v1.6.5 which should fix the type issue

[insertmike]

Fixed in v1.6.5 💯