Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global use of 'window' breaks apps with SSR #54

Open
ispyinternet opened this issue Feb 4, 2025 · 0 comments
Open

global use of 'window' breaks apps with SSR #54

ispyinternet opened this issue Feb 4, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@ispyinternet
Copy link

ispyinternet commented Feb 4, 2025 •
edited
Loading

Can you fix the dependency on window in

const broadcastChannel = new window.BroadcastChannel("pub-sub-es");

So that it silently handles when window is not available, without it I have to faff around with conditional import and promises to get a pubSub instance in the browser.
@ispyinternet ispyinternet changed the title Feature request: subscribe using event wildcard or pattern matching global use of 'window' breaks apps with SS$ Feb 4, 2025
@ispyinternet ispyinternet changed the title global use of 'window' breaks apps with SS$ global use of 'window' breaks apps with SSR Feb 4, 2025
@flekschas flekschas added the bug Something isn't working label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flekschas @ispyinternet