Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseIn fallbck is used even if preference is set to none for interfaces within portals.conf file #1254

Closed
SoumyaRanjanPatnaik opened this issue Dec 31, 2023 · 1 comment · Fixed by #1255
Labels
bug config Issues with the portal configuration mechanism needs diagnosis Root cause of the issue needs to be diagnosed

Comments

@SoumyaRanjanPatnaik
Copy link
Contributor

SoumyaRanjanPatnaik commented Dec 31, 2023

Operating System

Ubuntu 23.10 (mantic)

XDG Desktop Portal version

1.18

XDG Desktop Portal version (Other)

No response

Desktop Environment

Other

Desktop Environment (Other)

Regolith

Expected Behavior

  • If the preferred value for an interface is set to none in portals.conf, the interface should be disabled.
  • If the default preference is set to none, all the interfaces should be disabled, except the ones that explicitly specify some other backend in their preference list

Current Behavior

X-D-P ignores none values in portals.conf file, if the UseIn value is specified by any of the backends

Steps to Reproduce

  1. Install a portals backend that uses the legacy UseIn field in its .portals file (example: X-D-P-gnome)
  2. In your portals.conf file, set the preference for any interface supported by the backend. I used the following for gnome.
    org.freedesktop.impl.portal.Background=none
    
  3. Run /usr/libexec/xdg-desktop-portal -r -v

Result: the interface is not disabled

XDP: Found 'none' in configuration for org.freedesktop.impl.portal.Background

(/usr/libexec/xdg-desktop-portal:81335): xdg-desktop-portal-WARNING **: 19:29:21.131: Choosing gnome.portal for org.freedesktop.impl.portal.Background via the deprecated UseIn key

(/usr/libexec/xdg-desktop-portal:81335): xdg-desktop-portal-WARNING **: 19:29:21.131: The preferred method to match portal implementations to desktop environments is to use the portals.conf(5) configuration file
XDP: Using gnome.portal for org.freedesktop.impl.portal.Background in gnome (fallback)

Anything else we should know?

Setting default to none produces the same behaviour but for all the interfaces provided by the backends with UseIn in their .portal file

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 31, 2023
@SoumyaRanjanPatnaik SoumyaRanjanPatnaik changed the title UseIn fallbck is used even if preference is set to nonefor interfaces within portals.conffile UseIn fallbck is used even if preference is set to none for interfaces within portals.conf file Dec 31, 2023
@GeorgesStavracas GeorgesStavracas added config Issues with the portal configuration mechanism needs diagnosis Root cause of the issue needs to be diagnosed labels Dec 31, 2023
@SoumyaRanjanPatnaik
Copy link
Contributor Author

Potential fix: #1255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug config Issues with the portal configuration mechanism needs diagnosis Root cause of the issue needs to be diagnosed
Projects
No open projects
Status: Triaged
2 participants