You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are quite similar, but we'll need to figure out what our convention is for dtypes (should it be the real or complex or should we accept both). Here I think it makes sense for cufinufft to default to single precision even though finufft defaults to double precision. This should be more in line with what one would expect for CPU/GPU codes, but I'm open to suggestions here.
Obviously the name needs to change. (set_pts to setpts) but perhaps also the argument names. Should think about extending the interface to handle type 3 even if it's not implemented yet.
These behave quite differently in that data is always input for finufft, but for cufinufft either c or fk can be input (the other is output) depending on the type. Ideally, we should also allow the user to return an array.
Finally, we should consider renaming the cufinufft class to Plan similar to the finufft case.
The text was updated successfully, but these errors were encountered:
Similar to #255, we need to align the interfaces for finufft and cufinufft in Python.
init
These are quite similar, but we'll need to figure out what our convention is for dtypes (should it be the real or complex or should we accept both). Here I think it makes sense for cufinufft to default to single precision even though finufft defaults to double precision. This should be more in line with what one would expect for CPU/GPU codes, but I'm open to suggestions here.
setpts
Obviously the name needs to change. (
set_pts
tosetpts
) but perhaps also the argument names. Should think about extending the interface to handle type 3 even if it's not implemented yet.execute
These behave quite differently in that
data
is always input for finufft, but for cufinufft eitherc
orfk
can be input (the other is output) depending on the type. Ideally, we should also allow the user to return an array.Finally, we should consider renaming the
cufinufft
class toPlan
similar to the finufft case.The text was updated successfully, but these errors were encountered: