Updated default option handling for CLI #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaults were overriding settings specified for colorize and timestamp. I added a check to see if it's been set, otherwise, default.
|
So, I believe the issue revolves around calling cli() after constructing the transport |
|
This does become a non-issue if you don't call .cli() after constructing your transport. I have since moved it to the default winston object where I was previously having issues and needing to call again. If this change doesn't cause any other known issues, I'd still recommend it though. Thanks! |
|
👍 but we need tests. |
indexzero
added a commit
that referenced
this pull request
Feb 3, 2015
Updated default option handling for CLI
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults were overriding settings specified for colorize and timestamp. I added a check to see if it's been set, otherwise, default.