-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild cannot bundle nconf #386
Comments
I'm also getting hit by this, can a publish be done with the fix commit - ce212b2 ? 🙏 |
(cherry picked from commit ce212b2)
would love to see a publish of this as well! |
yes, this would be good to backport and publish. my only hesitation is that |
If anyone still has this issue, you can work around it using this fix. |
(cherry picked from commit ce212b2)
nconf v0.12.1 has been released with this change. |
Due to dynamic require of stores, esbuild cannot bundle nconf. See following warning when bundling with esbuild:
Since the list of builtin stores is static, they're is no need to make dynamic require.
Possible workaround: specify an esbuild inject scripts, eg
esbuild --bundle --inject:esbuild-inject.js src/index.js
with esbuild-inject.js
However it would be more convenient to avoid that.
The text was updated successfully, but these errors were encountered: