Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backups Don't Work #448

Open
DarkArc opened this issue Feb 26, 2024 · 5 comments
Open

Backups Don't Work #448

DarkArc opened this issue Feb 26, 2024 · 5 comments

Comments

@DarkArc
Copy link

DarkArc commented Feb 26, 2024

The Standard Notes Backups feature doesn't seem to work, it ends up mapping to something like /run/user/1000/doc/bla bla bla rather than the selected folder.

@DarkArc
Copy link
Author

DarkArc commented Feb 26, 2024

Giving increased file system access (vs the flatpak defaults) doesn't seem to resolve the issue.

Generally though, it seems like having access to user files/the home directory would make the most sense so the app has access to write backups anywhere the user (reasonably) selects.

@salad612
Copy link

salad612 commented Mar 31, 2024

I think, instead of creating the Documents and Standard Notes Backups folder in the sandbox, the app should be given access to ~/Documents/standardnotes:create and ~/Standard Notes Backups:create directly. I disagree on giving access to the whole home directory though, I don't think the sandbox should be broken for a setting that most users won't change from the default.

@proletarius101
Copy link
Collaborator

To my understanding, the directory names of the backups are different by accounts. It's almost impossible to just grant a fine-grained file system access.

On the other hand, if you choose a custom location, the access will be automatically granted.

@salad612
Copy link

salad612 commented Mar 31, 2024

To my understanding, the directory names of the backups are different by accounts. It's almost impossible to just grant a fine-grained file system access.

On the other hand, if you choose a custom location, the access will be automatically granted.

But that directory is INSIDE the Documents/standardnotes folder, right? If you grant access to that folder, I believe it should work. Although, I did not test this myself.

As for the custom location, the portal doesn't seem to work properly for whatever reason. CHOOSING a location works, but when you actually make the backup or press open folder it results in what OP got, some /run/user/1000/ whatever.

@DarkArc
Copy link
Author

DarkArc commented Mar 31, 2024

I disagree on giving access to the whole home directory though, I don't think the sandbox should be broken for a setting that most users won't change from the default.

I think being pedantic about the app's sandbox surface area is not particularly useful.

The app has a feature to allow the user to put backups wherever they like. I don't think it's a reasonable thing to assume that most people (or even an insignificant percentage of people) would like to change this location.

Also remember, this is an open source and audited app; not some random proprietary blob that's likely to be untrustworthy.

As for the custom location, the portal doesn't seem to work properly for whatever reason. CHOOSING a location works, but when you actually make the backup or press open folder it results in what OP got, some /run/user/1000/ whatever.

Yes, this.

It's worth noting this used to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants