Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to connect to Browser Plugin or SSH Agent #19

Closed
kurobeats opened this issue Jun 11, 2018 · 7 comments
Closed

Unable to connect to Browser Plugin or SSH Agent #19

kurobeats opened this issue Jun 11, 2018 · 7 comments
Assignees

Comments

@kurobeats
Copy link

Title says it all. The application is unable to connect to the Browser Plugin or SSH Agent.

I suspect this is by design as it is a containerised application but it should be considered that the security in this instance is affecting core (optional) functionality.

@AsavarTzeth
Copy link
Collaborator

AsavarTzeth commented Jun 11, 2018

This is partly a duplicate of #13. See that issue for a great deal of detail about the browser extension.

The short version is that its not as simple as just allowing access to the required files & sockets.

At the moment it is either very difficult or impossible to make this work. This is especially true when the app relies on external resources, or running services.

Be assured that I am always exploring ways to make these features work and I do take suggestions.

To be clear, I am not ignoring these issues due to some security concern.

@kurobeats
Copy link
Author

thank you for your response.

@kurobeats kurobeats reopened this Jun 11, 2018
@AsavarTzeth AsavarTzeth self-assigned this Jun 26, 2018
@AsavarTzeth
Copy link
Collaborator

Flatpak 0.99.1 introduced the ability to use --socket=ssh-auth to grant access to the ssh agent.

Since you probably have more experience than I with the KeePassXC ssh-agent feature, I would very much appreciate if you could test this with:

flatpak run --socket=ssh-auth org.keepassxc.KeePassXC//stable

If this does not work, could you share more information on how things should look and behave when it does work?

@kurobeats
Copy link
Author

kurobeats commented Jun 27, 2018

Looks like fedora 28 is running an older version:

$ flatpak run --socket=ssh-auth org.keepassxc.KeePassXC//stable error: Unknown socket type ssh-auth, valid types are: x11, wayland, pulseaudio, session-bus, system-bus, fallback-x11
$ flatpak --version Flatpak 0.11.8.3

@AsavarTzeth
Copy link
Collaborator

Yeah it does not surprise me, since the 0.99.1 release is a pre-release for the stable 1.0.

For some reason Arch Linux happens to use it.

In either case I suppose I cannot rely upon it until 1.0 then.

On the bright side I finally fixed the browser integration. Just about to force a rebuild due to some Flathub issues earlier.

@hifi
Copy link

hifi commented Jul 26, 2018

I can confirm --socket=ssh-auth does make it work with Flatpak 0.99.3 pulled from their own PPA on Linux Mint 19.

@AsavarTzeth
Copy link
Collaborator

AsavarTzeth commented Jul 27, 2018

Excelent! Thank you for testing.

Now we just need various distributions to catch up. Or at least it would make sense to wait for the next LTS (stable) release of flatpak.

Then I can add this by default in the manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants