-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop eclass tests, move obsolete eclasses to overlay #2248
Conversation
We weren't syncing that for ages and we are not running those tests, so drop the directory altogether.
They were removed from Gentoo. We still have users of those in overlay, though.
CI passed (I didn't run any tests - no package has changed, so I was only checking if stuff still builds.) |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10512648558 |
|
Okay, I see it is inherited by eutils. You could just remove that entry though. |
To be honest, I'd rather just drop the few remaining instances of EAPI 6. Gentoo has literally just purged almost all of them this week. It won't take me long at all. |
That's obviously I'd like to eventually do. I think that the only Gentoo-derivative user of these eclasses in our overlay is For now I wanted to just move the obsolete eclasses, so that nothing breaks and the github automation will stop complaining about them being missing in Gentoo. |
As discussed elsewhere, I have dropped all instances of EAPI 6, so we can just remove these eclasses now. I will open a new PR to succeed this one. |
We weren't syncing the eclass tests for ages and we weren't running them, so their existence in portage-stable is pointless at the moment. Also, three eclasses were removed from Gentoo, so we move them to our overlay as there is still a package or two that are using them.
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1682/cldsv/