feat: add a use_softmax field in variant class
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
added a commit
that referenced
this pull request
Oct 17, 2024
…ions (#532) The qkv data type in `run` function must match with the q/kv data type specified in `plan` functions, otherwise the plan function might produce wrong schedules. feat: add a `use_softmax` field in variant class (#533) If true, use online softmax rules to update attention states. If not, simply adding the partial attention results. In the future, we can generalize this as a state update function. upd upd add flash sigmoid upd upd upd upd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If true, use online softmax rules to update attention states.
If not, simply adding the partial attention results.
In the future, we can generalize this as a state update function.