-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect relays statuses in status
endpoint
#169
Comments
I think that could make sense. Would love to hear inputs from the other CL clients on this too! |
I see a problem with this approach, namely that mev-boost uses it's internal request timeout, waiting for the slowest relay. But it has no notion about the BN timeout for this call. Thus even if a relay already responded okay, boost would still wait for further relay responses. Either we should allow the BN to pass the request timeout as argument, or we should revert this change. Any thoughts? |
I think mev-boost should respond immediately as soon as the first relay responds ok. (So it requires calling status in parallel against all relays). Another approach could be to detach the calls. Mev-boost can do it's own polling to relays and maintain its own view of the situation, so the mev-boost can respond immediately with its current view. |
Good ideas! Thanks 👍 |
The second approach adds a bit of latency but saves from the need of coordinating the timeouts, so slightly prefer that over the first option :) |
Implemented the first option in v0.7.2, moving to option 2 in the future |
What timeout are you applying on the relays call? |
The default timeout used for all requests. But perhaps that's not good enough and we need to define them per request... See also #181 |
finished |
I think
mev-boost
status endpoint should callstatus
endpoints for each relays and return OK if at least one returned OK. Otherwise it should return KO (503?).The text was updated successfully, but these errors were encountered: