From a3ca2d200e413017b92a7a84a9ba2e68dbc7cd15 Mon Sep 17 00:00:00 2001
From: Ryland Herrick <ryalnd@gmail.com>
Date: Tue, 25 Feb 2020 21:30:37 -0600
Subject: [PATCH] Remove support of HEAD request in signals index route
 (#58489) (#58540)

Until these are officially supported in new platform, it's best to not
rely on this behavior. We can achieve roughly the same functionality
with a GET request. Modifies the existing script accordingly, in case
anyone's still using it.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../routes/index/read_index_route.ts          | 25 ++++++-------------
 .../scripts/signal_index_exists.sh            |  4 +--
 2 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/index/read_index_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/index/read_index_route.ts
index 1a5018d446747..0bcdf61e48bf2 100644
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/index/read_index_route.ts
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/index/read_index_route.ts
@@ -29,25 +29,14 @@ export const createReadIndexRoute = (server: ServerFacade): Hapi.ServerRoute =>
         const callWithRequest = callWithRequestFactory(request, server);
         const indexExists = await getIndexExists(callWithRequest, index);
         if (indexExists) {
-          // head request is used for if you want to get if the index exists
-          // or not and it will return a content-length: 0 along with either a 200 or 404
-          // depending on if the index exists or not.
-          if (request.method.toLowerCase() === 'head') {
-            return headers.response().code(200);
-          } else {
-            return headers.response({ name: index }).code(200);
-          }
+          return headers.response({ name: index }).code(200);
         } else {
-          if (request.method.toLowerCase() === 'head') {
-            return headers.response().code(404);
-          } else {
-            return headers
-              .response({
-                message: 'index for this space does not exist',
-                status_code: 404,
-              })
-              .code(404);
-          }
+          return headers
+            .response({
+              message: 'index for this space does not exist',
+              status_code: 404,
+            })
+            .code(404);
         }
       } catch (err) {
         const error = transformError(err);
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/scripts/signal_index_exists.sh b/x-pack/legacy/plugins/siem/server/lib/detection_engine/scripts/signal_index_exists.sh
index b4a494a102b54..ec3e0595c7b08 100755
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/scripts/signal_index_exists.sh
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/scripts/signal_index_exists.sh
@@ -10,7 +10,7 @@ set -e
 ./check_env_variables.sh
 
 # Example: ./signal_index_exists.sh
-curl -s -k --head \
+curl -s -k -f \
  -H 'Content-Type: application/json' \
  -u ${ELASTICSEARCH_USERNAME}:${ELASTICSEARCH_PASSWORD} \
- ${KIBANA_URL}${SPACE_URL}/api/detection_engine/index
+ ${KIBANA_URL}${SPACE_URL}/api/detection_engine/index > /dev/null