Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependency features #73

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

m4tx
Copy link
Member

@m4tx m4tx commented Nov 20, 2024

This also removes the regex dependency as it was easily replaced with some simple text-handling code.

This PR reduces the number of compiled units for the examples/sessions crate from 312 to 252. This allows me to reduce the clean build time from 22.7 seconds to 18.8 seconds on my laptop.

image

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
rust 82.79% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
flareon/src/router/path.rs 100.00% <100.00%> (+3.34%) ⬆️

🚨 Try these New Features:

@m4tx m4tx force-pushed the clean-dep-features branch from dc081c9 to 8b8e2b4 Compare November 20, 2024 08:59
@m4tx m4tx requested review from seqre and Iipin November 20, 2024 09:08
Copy link
Member

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please mind the comment

@seqre
Copy link
Member

seqre commented Nov 20, 2024

This allows me to reduce the clean build time from 22.7 seconds to 18.8 seconds on my laptop.

image

This also removes `regex` dependency as it was easily replaced with some
simple text-handling code.
@m4tx m4tx force-pushed the clean-dep-features branch from 8b8e2b4 to 427be8b Compare November 20, 2024 10:10
@m4tx m4tx merged commit b62f958 into master Nov 20, 2024
21 of 23 checks passed
@m4tx m4tx deleted the clean-dep-features branch November 20, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants