Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: crash on pinning screenshot to the desktop #2687

Closed
adem4ik opened this issue Jun 20, 2022 · 4 comments
Closed

Regression: crash on pinning screenshot to the desktop #2687

adem4ik opened this issue Jun 20, 2022 · 4 comments
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.

Comments

@adem4ik
Copy link
Contributor

adem4ik commented Jun 20, 2022

Flameshot Version

Flameshot v12.0.0 (adb58e2)

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

Windows 10 x64

Description

Flameshot crashes after trying to pin screenshot to the desktop. I've got the installer from https://github.com/flameshot-org/flameshot/actions/runs/2520717952 . It seems like the issue may be result of this commit - adb58e2 . 12.0.rc1 doesn't have such issue.

Steps to reproduce

  1. run flameshot
  2. make a screenshot
  3. try to pin it to the desktop

Screenshots or screen recordings

image

System Information

Windows 10, single monitor with 1600x900 resolution.
@adem4ik adem4ik added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jun 20, 2022
@borgmanJeremy
Copy link
Contributor

Thanks, I've revered that commit. I'll wait to mess with this until after the release.

@borgmanJeremy borgmanJeremy mentioned this issue Jun 20, 2022
Merged
@adem4ik
Copy link
Contributor Author

adem4ik commented Jun 20, 2022

Thank you, checked with artifacts from https://github.com/flameshot-org/flameshot/actions/runs/2529556850 , no more crashes.

@Alaskra
Copy link
Contributor

Alaskra commented Jun 22, 2022

Sorry to introduce this bug, I have add this pr #2698 and hopes fix it.

@adem4ik
Copy link
Contributor Author

adem4ik commented Jun 22, 2022

@Alaskra np, I'll test your pr.

@adem4ik adem4ik mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adem4ik @borgmanJeremy @Alaskra