Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow opening images from clipboard #2005

Open
MadaraUchiha opened this issue Oct 24, 2021 · 8 comments
Open

Feature Request: Allow opening images from clipboard #2005

MadaraUchiha opened this issue Oct 24, 2021 · 8 comments
Labels
Enhancement Feature requests and code enhancements

Comments

@MadaraUchiha
Copy link

Is your feature request related to a problem?

Feature

Please consider adding the ability to open the current graphic found in the clipboard as a quick way to add markings onto a copied image

Reasoning

It can sometimes be useful to take an image copied from the web (copying it instead of taking a screenshot of it to avoid graphic data loss), or a screenshot taking with Firefox's tool (as it fits more than one "scroll page" in it). Being able to open images already copied to the clipboard from outside of Flameshot would be a really cool feature to have.

Extras

  • Not part of the same FR (one per, right?) - But I assume it would be trivial to also implement opening from a file.
  • A similar feature exists for the Windows based Greenshot, that one however features an entire editor as its own sub-process.
@veracioux veracioux added the Enhancement Feature requests and code enhancements label Oct 24, 2021
@veracioux
Copy link
Contributor

Usually, I am against bloating flameshot with features best reserved for a dedicated image editor. But I think this this is an exception because we can interconnect it with other features to achieve a very elegant ecosystem:

  • Edit images from the clipboard (CLI, best by piping xclip ... through stdin)
  • Edit images from a file (CLI, introducing an option and also from stdin)
  • Allow the user to drag from/to the launcher window (System Tray Flameshot Icon -> Open Launcher)
  • Give the launcher a "from clipboard" button (or equivalent)
  • Give the launcher a "from file" button (or equivalent)
  • Apply user watermarks to images using any of the above

Most of these have had issues opened for them.

The problem is how to display the input image, if it is smaller than the screen(s). There are multiple strategies we can use:

  • Open the input image, and make everything around it black
  • Open the input image on top of the screenshot of the screen
  • Scale the input image so it covers the entire screen
  • Make the input image draggable and resizable (requires a lot of work, and code refactoring potentially)
  • Open the capture GUI in windowed mode, so the window matches the image size (only possible after Windowed capture mode #1565 is merged)

We can think of more.
If we were to implement these features, we would have to give a lot of thought to it, to avoid creating a bloated pile of garbage.

Discussion/suggestions are welcome.

@mmahmoudian
Copy link
Member

mmahmoudian commented Oct 24, 2021

@MadaraUchiha

it would be trivial to also implement opening from a file.

This is a 分身の術 (Duplicate) 😉 of #1100


@veracioux

Open the capture GUI in windowed mode, so the window matches the image size (only possible after Windowed capture mode #1565 is merged)

This is the most trivial UI imho.

I agree that this is beneficial enough not to be considered as bloat.

@veracioux
Copy link
Contributor

@mmahmoudian

This is the most trivial UI imho.

Yeah, but we'll probably have to use another strategy for the watermark feature.

@AllroadsNL
Copy link

AllroadsNL commented Apr 4, 2022

I did search on watermark/stamp, I thought this is the best post to post a comment and not opening a new issue.

Screenshot image license embedding

Looking for a tool which can do this:

Embed licence attribution image (prefered, because of reusing image) (transparent) or attribution preset text in screenshot.

PrtScr--> Flameshot app --> drag a box --> select a map or a website ( preset attribution images pool) --> drag and drop image in screenshot--> customize it --> copy it and paste it ( in a forum to communicate) or save it.

T, Text field: you can CTRL-V it, but you must CTRL-C it from somewhere (attribution testpool) in front of making a screenshot and then make a screenshot, this is a disadvange. You can not copy paste twice other lines of text.

Screenshot images, it is all about license.
And give credit to the image original maker, when you make a screenshot, © Name (license)
or with give extra information "modified"
Important is the workflow, how easy can it be done. In less steps to get the result.
Now I see a lot of images, screenshots that are not attributed. They should.

Problem is the workflow and the best tool for it.

I hope that this feature can be a enhancement in the near future, it would be a key userpoint to use flameshot.

@mmahmoudian
Copy link
Member

mmahmoudian commented May 4, 2022

@AllroadsNL This sounds like a good candidate for a plugin. We are planning on a plugin system: #2529

@AllroadsNL
Copy link

@mmahmoudian
A topic about what to use, image and licence is important.
Openstreetmap community

The problem is when flamshot is active, I can not reach a folder document or a website to copy paste text from somewhere else to use it in the text field.
Going to a editor (flameshot) then you have programs working side by side. Then it is possible copy/paste to each other.

@mmahmoudian
Copy link
Member

mmahmoudian commented May 5, 2022

@AllroadsNL
Here are few points that imho is worth mentioning:

  1. there should be a distinction (practical, idealogical, conceptual) between a photo editing tool like Gimp, Krita, and Inkscape, and a screenshot tool that let you annotate your screenshot.

  2. License is what the user should consider, it is out of jurisdiction of a screenshot tool to enforce licensing (e.g git doesn't force you to have a LICENSE file when you do git init). If the user want, they can easily modify the metadata with a script that is bound to a hook (e.g take a look at entr)

  3. The point of having a plugin is to give the users some extra abilities and functionalities that are useful but not everyone might want to use it. This way those who want to have the functionality can use the plugin and others don't suffer from the bloat

@cjkepinsky
Copy link

this is what I am missing in this app, as a tester I often go back and forth adding text, squares, arrows, etc., to the screenshot. In other words ability to cycling the screenshot between Flameshot and clipboard would be very appreciated, as many ppl in IT use such tools :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

5 participants