Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary "share/*" directories installed on Windows #1453

Closed
hosiet opened this issue Mar 11, 2021 · 7 comments · Fixed by #1992
Closed

Unnecessary "share/*" directories installed on Windows #1453

hosiet opened this issue Mar 11, 2021 · 7 comments · Fixed by #1992
Assignees
@AdavisSnakes
Labels
Bug It's a bug Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.

Comments

@hosiet
Copy link
Member

hosiet commented Mar 11, 2021

Flameshot version
(All versions)

Describe the bug
There are lots of Linux-only files installed when Windows MSI package is installed:

图片

Probably we should add an if() statement in src/CMakeLists.txt file and do not call those configure_file() instructions on Windows/Mac platform.

Expected behavior
Unnecessary files under C:\Program Files\Flameshot\share\ should not exist.

System Information
Any Windows system
@borgmanJeremy borgmanJeremy added the Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed. label Mar 15, 2021
@e-hat
Copy link

e-hat commented Apr 2, 2021

Can I take this one?

@borgmanJeremy
Copy link
Contributor

Yes please do

@mmahmoudian mmahmoudian added the Bug It's a bug label Apr 2, 2021
@AdavisSnakes
Copy link
Contributor

@e-hat, are you still looking into this issue? I wouldn't mind looking at it if you've gotten busy.

@mmahmoudian
Copy link
Member

@e-hat have you had any progress? Do you mind if we sign this issue to @AdavisSnakes who seems to have time?

@e-hat
Copy link

e-hat commented Oct 19, 2021

@mmahmoudian sorry for the late reply! Yes, that is fine with me.

@mmahmoudian mmahmoudian assigned AdavisSnakes and unassigned e-hat Oct 20, 2021
@mmahmoudian
Copy link
Member

@AdavisSnakes the floor is all yours

@AdavisSnakes AdavisSnakes mentioned this issue Oct 21, 2021
Merged
@mmahmoudian
Copy link
Member

@AdavisSnakes Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdavisSnakes AdavisSnakes

Labels
Bug It's a bug Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unnecessary share folder on windows AdavisSnakes/flameshot
5 participants
@mmahmoudian @hosiet @e-hat @borgmanJeremy @AdavisSnakes