[proposal] Omit empty TiledImage from TiledMap.tiledImages

[Hwan-seok]

What could be improved

Note: I am not sure if this is a bug or a proposal.

Change the TiledMap.tiledImages to return only tilesets that have an actual source.

tiled.dart/packages/tiled/lib/src/tiled_map.dart

Lines 205 to 215 in 1d3043f

	final imageSet = <TiledImage>{};
	for (var i = 0; i < tilesets.length; ++i) {
	final image = tilesets[i].image;
	if (image != null) {
	imageSet.add(image);
	}
	for (var j = 0; j < tilesets[i].tiles.length; ++j) {
	final image = tilesets[i].tiles[j].image;
	if (image != null) {
	imageSet.add(image);
	}

As-is
if (image != null) {
  imageSet.add(image);
}

imageSet.addAll(layers.whereType<ImageLayer>().map((e) => e.image));

To-be
if (image?.source != null) {
  imageSet.add(image!);
}

imageSet.addAll(layers.whereType<ImageLayer>().map((e) => e.image)).where((e) => e.source != null);

Why should this be improved

At present, TiledMap.tiledImages collects all images in the map including those without the source.
I think the TiledImages without source is not actually the "image".

For example, the following is a bare image layer without the source:

 <imagelayer id="4" name="Image Layer 2"/>

I think it is a layer but doesn't include any image.

The following is another example:

 <tileset firstgid="1810" name="tileset 1" tilewidth="1" tileheight="1" tilecount="0" columns="0"/>

Also, this is a tileset but not includes any "image".

Any risks?

This cannot be true but there might be some users that use the empty Tiledimage.

More information

[spydon]

Sounds like a good improvement, should I assign you to the issue?

[Hwan-seok]

It would be great :)