You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
while(node=getContainingBlock(node)){conststyle=getComputedStyle(node);switch(style['overflow-x']){case'auto':
case'scroll':
case'hidden':
// https://drafts.csswg.org/css-overflow-3/#overflow-propagation// The UA must apply the overflow from the root element to the viewport;// however, if the overflow is visible in both axis, then the overflow// of the first visible child body is applied instead.if(node==document.body&&getComputedStyle(document.scrollingElement).overflow=="visible")returndocument.scrollingElement;returnnode;}}
The function getScrollParent currently only checks style.overflowX, which is incorrect because vertical scrolling depends on overflowY.
This means an element will only be considered a scroll container if it has horizontal (overflowX) scrolling.
The text was updated successfully, but these errors were encountered:
The bug is here
https://github.com/flackr/scroll-timeline/blob/master/src/scroll-timeline-base.js#L570-L585
The function getScrollParent currently only checks style.overflowX, which is incorrect because vertical scrolling depends on overflowY.
This means an element will only be considered a scroll container if it has horizontal (overflowX) scrolling.
The text was updated successfully, but these errors were encountered: