You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently ran into an issue where an important workflow was skipped when it shouldn't have been, leading to a lot of confusion and time spent hunting down the issue. I believe the problem is due to the commit that was skipped having nearly 2,000 changed files. Looking at the code, it doesn't seem to be doing any pagination check when the documentation says that it only returns up to 300 files at a time.
I understand if for performance reasons you don't want to check over 300 files per commit, but in those cases I suggest emitting a warning and marking path filtering as "found a change" so the workflow isn't accidentally skipped.
The text was updated successfully, but these errors were encountered:
I recently ran into an issue where an important workflow was skipped when it shouldn't have been, leading to a lot of confusion and time spent hunting down the issue. I believe the problem is due to the commit that was skipped having nearly 2,000 changed files. Looking at the code, it doesn't seem to be doing any pagination check when the documentation says that it only returns up to 300 files at a time.
I understand if for performance reasons you don't want to check over 300 files per commit, but in those cases I suggest emitting a warning and marking path filtering as "found a change" so the workflow isn't accidentally skipped.
The text was updated successfully, but these errors were encountered: