Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path filtering silently fails with large number of files #349

Open
cyreb7 opened this issue Jan 12, 2025 · 0 comments
Open

Path filtering silently fails with large number of files #349

cyreb7 opened this issue Jan 12, 2025 · 0 comments

Comments

@cyreb7
Copy link

cyreb7 commented Jan 12, 2025

I recently ran into an issue where an important workflow was skipped when it shouldn't have been, leading to a lot of confusion and time spent hunting down the issue. I believe the problem is due to the commit that was skipped having nearly 2,000 changed files. Looking at the code, it doesn't seem to be doing any pagination check when the documentation says that it only returns up to 300 files at a time.

I understand if for performance reasons you don't want to check over 300 files per commit, but in those cases I suggest emitting a warning and marking path filtering as "found a change" so the workflow isn't accidentally skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant