Fix broken cwe_checker plugin #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts output format, we now have to parse json instead of sexp
dorpvom
requested changes
Jul 31, 2019
| if 'WARN' in line: | ||
| cwe_warning = cwe_parser.parse(line) | ||
| tmp[cwe_warning.name].append(cwe_warning) | ||
| j = json.loads(output) |
There was a problem hiding this comment.
If you have pre-commit set up, this would not have been allowed. Please use more semantic name to comply with coding guidelines
| j = json.loads(output) | ||
| if 'warnings' in j: | ||
| for warning in j['warnings']: | ||
| tmp[warning['name']] = tmp[warning['name']] + [warning] |
There was a problem hiding this comment.
I'd prefer the [warning, ] syntax to explicitly show warning to be one element. If warning would be a string, the string would be split into chars using the syntax without trailing comma
| echo "Cleaning up" | ||
| rm -rf internal/src/_build | ||
| rm -f internal/src/cwe_checker.plugin | ||
|
|
There was a problem hiding this comment.
Please also remove sexpdata installation
dorpvom
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cwe_checker changed its output format, we have to parse json instead of sexp. Good news: this makes the FACT plugin much smaller! 👍
Please do not merge before PR #32 of cwe_checker has been merged (fkie-cad/cwe_checker#32).