Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test methods createClientConfigurationWeakSSL() and createClientConfigurationWeakSSL() have the same body #30

Open
informatik01 opened this issue Dec 31, 2021 · 1 comment

Comments

@informatik01
Copy link

informatik01 commented Dec 31, 2021

Hi.

Noticed that two helper methods in the SslSessionTest class despite having different names have the same body (and the same logic).
I am meant the following methods:

Was is done on purpose for some reason or it was accidently left like this?

@informatik01
Copy link
Author

informatik01 commented Dec 31, 2021

The related test method trustedClientSSL() is currently marked with @Ignore annotation because it fails with the current incorrect implementation of the createClientConfigurationStrongSSL() helper method.

I managed to update the code of the createClientConfigurationStrongSSL() helper method to successfully run the trustedClientSSL() test method: added the missing SSL configurations and imported a self-made certificate into the keystore used in the tests.

At least I am satisfied with the result 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant