Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add not statement for multi touch resolution metric #74

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# dbt_zendesk v0.8.4
## Bug Fix
- Quick fix on missing logic in the case statement for determining multi-touch resolution metrics.
# dbt_zendesk v0.8.3
## Features
- This [Zendesk Source package](https://github.com/fivetran/dbt_zendesk_source) now allows for custom fields to be added to the `stg_zendesk__ticket` model. These custom fields will also persist downstream to the `zendesk__ticket_enriched` and `zendesk__ticket_metrics` models. You may now add your own customer fields to these models by leveraging the `zendesk__ticket_passthrough_columns` variable. ([#70](https://github.com/fivetran/dbt_zendesk/pull/70))
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'zendesk'
version: '0.8.3'
version: '0.8.4'

config-version: 2
require-dbt-version: [">=1.0.0", "<2.0.0"]
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
config-version: 2

name: 'zendesk_integration_tests'
version: '0.8.3'
version: '0.8.4'

profile: 'integration_tests'

Expand Down
2 changes: 1 addition & 1 deletion models/zendesk__ticket_enriched.sql
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ with ticket as (
requester_org.updated_at as requester_organization_updated_at,
submitter.external_id as submitter_external_id,
submitter.role as submitter_role,
case when submitter.role in ('Agent','Admin')
case when submitter.role in ('agent','admin')
then true
else false
end as is_agent_submitted,
Expand Down
3 changes: 2 additions & 1 deletion models/zendesk__ticket_metrics.sql
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ select
then true
else false
end as is_two_touch_resolution,
case when lower(ticket_enriched.status) in ('solved','closed') and not ticket_comments.is_one_touch_resolution
case when lower(ticket_enriched.status) in ('solved','closed') and not ticket_comments.is_one_touch_resolution
and not ticket_comments.is_two_touch_resolution
then true
else false
end as is_multi_touch_resolution
Expand Down