add not statement for multi touch resolution metric #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Tony Tushar, Sr Analytics Engineer, Apto Payments
What change(s) does this PR introduce?
PR is a quick fix on a missing logic in a case statement for determining multi-touch resolution metric. I noticed in our data that 32k records were being defined as both two and multi-touch = 1, so this fix corrects for that.
Additional fix on
is_agent_submitted
case statement where admin, agent should be all lowercase.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This change is a minor additional clause in a case statement, no breaking changes introduced by this.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
I initially ran this statement in my project and received 32k records in response where
is_two_touch_resolution
andis_multi_touch_resolution
both equalTrue
. Once I made the change suggested in this PR, I did not receive any rows back.Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
😎
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.