Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release to include source changes in Quickstart #180

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Dec 9, 2024

PR Overview

This PR will address the following Issue/Feature:
Patch release to include fix from fivetran/dbt_zendesk_source#58 for https://getdbt.slack.com/archives/C01D1R2JLLA/p1733513338340409

This PR will result in the following new package version:

v0.19.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • In v0.19.0, Snowflake users may have seen when searching for a relation, dbt found an approximate match errors when running the stg_zendesk__group_tmp model. We have updated the adapter.get_relation() logic that was causing this error in the zendesk_source package.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

See validation from fivetran/dbt_zendesk_source#58

If you had to summarize this PR in an emoji, which would it be?

🩹

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie Small suggestion but lgtm!

CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit 6b8c218 into main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants