Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Multi-touch ticket resolution logic could be adjusted #75

Closed
2 of 4 tasks
fivetran-joemarkiewicz opened this issue Jun 10, 2022 · 0 comments
Closed
2 of 4 tasks
Labels
bug Something isn't working

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Initially brought to our attention by @tonytusharjr

The current logic within the zendesk__ticket_metrics model that calculates the multi-touch resolution could to be updated to ensure a ticket doesn't have both double and multi touch results. Below is the logic in question.

case when lower(ticket_enriched.status) in ('solved','closed') and not ticket_comments.is_one_touch_resolution
then true
else false
end as is_multi_touch_resolution

My one thought to not making this update is that multi-touch tickets are in fact also double touch tickets. We should confirm with the Zendesk metrics that these two types of tickets are inherently different before addressing this within the package.

Relevant error log or model output

SELECT * 
FROM `dbt_zendesk.zendesk__ticket_metrics` 
where is_multi_touch_resolution and is_two_touch_resolution

The above result may end with multiple records due to the current logic.

Expected behavior

Our package matches the metric definition defined by Zendesk for multi-touch ticket resolution.

dbt Project configurations

N/A

Package versions

packages:

  • package: fivetran/zendesk
    version: [">=0.8.0", "<0.9.0"]

What database are you using dbt with?

bigquery

dbt Version

v1.1.0

Additional Context

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants