Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new models #55

Merged
merged 36 commits into from
Dec 16, 2022
Merged

add new models #55

merged 36 commits into from
Dec 16, 2022

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Dec 6, 2022

Are you a current Fivetran customer?

Internal
What change(s) does this PR introduce?

  • Add new models stripe__invoice_details and stripe__account_daily_overview
  • Update stripe__invoice_line_items with pricing data and subscription_item_id
  • Remove the stripe__subscription_line_items model

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • [] No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • [] Yes
    Updated in union_feature branch

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-reneeli fivetran-reneeli changed the title start of account daily overview add new models Dec 6, 2022
@fivetran-reneeli
Copy link
Contributor Author

Note on stripe__subscription_line_items

  • For stripe__subscription_line_items I was thinking of just deleting this model since it's just taking invoice data and filtering for just those with a subscription id, so it's not that useful for customers. Further more we already have a stripe__subscription_details model.

@fivetran-reneeli
Copy link
Contributor Author

fivetran-reneeli commented Dec 12, 2022

Hi @fivetran-jamie this is ready for review. This branch contains updates for the following

  • new models invoice details and account daily overview (with new int_stripe__account_daily and int_stripe__date_spine)
  • update on models invoice line items

Note on stripe__subscription_line_items

  • For stripe__subscription_line_items I was thinking of just deleting this model since it's just taking invoice data and filtering for just those with a subscription id, so it's not that useful for customers. Further more we already have a stripe__subscription_details model.

Lmk if you have any questions!

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good! left some in-line Qs

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
models/stripe__account_daily_overview.sql Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
models/stripe__invoice_line_items.sql Outdated Show resolved Hide resolved
models/stripe__invoice_line_items.sql Show resolved Hide resolved
@fivetran-jamie
Copy link
Contributor

looks good to me! only addition i'd make is to the changelog -- maybe add the code for how they could essentially recreate the deleted stripe__subscription_line_items model

@fivetran-reneeli fivetran-reneeli merged commit f6314d7 into feature/stripe-updates-q4-2022 Dec 16, 2022
@fivetran-reneeli fivetran-reneeli mentioned this pull request Dec 16, 2022
14 tasks
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates labels Jan 10, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the new_models branch January 10, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants