-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new models #55
add new models #55
Conversation
Note on
|
Hi @fivetran-jamie this is ready for review. This branch contains updates for the following
Note on stripe__subscription_line_items
Lmk if you have any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good! left some in-line Qs
looks good to me! only addition i'd make is to the changelog -- maybe add the code for how they could essentially recreate the deleted |
Co-authored-by: Jamie Rodriguez <[email protected]>
Are you a current Fivetran customer?
Internal
What change(s) does this PR introduce?
stripe__invoice_details
andstripe__account_daily_overview
stripe__invoice_line_items
with pricing data andsubscription_item_id
stripe__subscription_line_items
modelDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Updated in
union_feature
branchIs this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.