Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Handle case where contact_link is missing #25

Closed
1 of 4 tasks
fivetran-jamie opened this issue Oct 14, 2024 · 1 comment
Closed
1 of 4 tasks

[Feature] Handle case where contact_link is missing #25

fivetran-jamie opened this issue Oct 14, 2024 · 1 comment
Assignees
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-jamie
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

It is possible for contact_link (and any other tables for that matter) to not exist in your WH even if it is selected in the Fivetran Connector Schema (it is a child table automatically synced through the opportunity endpoint).

The package should be able to run successfully in this case

How would you implement this feature?

Ideally, we totally avoid transformations related to contact_link -- here and in the transform package.

Option 1

Dynamically disable model using does_table_exist macro we will be leveraging in #23

Pro: Best/most seamless option if we can make it work
Con: However, I am not 100% certain that this will work with the order of dbt's parsing/compilation.

Option 2

Create empty table(s) if contact_link is not found a la our union_data macro

Pro: This is a relatively seamless option but
Con: Will produce 1-2 empty tables in the user's WH

Option 3

Add using_contact_link to turn off all transformations related to contact_link

Pro: Very straightforward to add
Con: May not work for Quickstart users, since the contact_link table may still be chosen in the connector schema tab

Describe alternatives you've considered

see above

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

@fivetran-catfritz
Copy link
Contributor

this is released, so closing out the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants