Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Update tests or models for multiple application_id records for a given opportunity_id #22

Open
1 of 4 tasks
fivetran-catfritz opened this issue Oct 23, 2024 · 1 comment
Labels
type:wontfix This will not be worked on

Comments

@fivetran-catfritz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

As of v0.6.0 and with our test data (will be provided in internal ticket), we sometimes have multiple application_id records associated with a given opportunity_id. This causes uniqueness test failures for lever__opportunity_enhanced and its upstream int models, which we should resolve.

How would you implement this feature?

We need to determine if the model needs to be adjusted to ensure only one record per opportunity_id is created, or if we should update the combination of column tests to add application_id.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz added the type:enhancement New functionality or enhancement label Oct 23, 2024
@fivetran-catfritz fivetran-catfritz changed the title [Feature] Update tests or models for multiple application_id records for a given opportunity_id [Bug] Update tests or models for multiple application_id records for a given opportunity_id Oct 28, 2024
@fivetran-catfritz fivetran-catfritz added type:bug Something is broken or incorrect and removed type:enhancement New functionality or enhancement labels Oct 28, 2024
@fivetran-catfritz
Copy link
Contributor Author

fivetran-catfritz commented Oct 29, 2024

According to the Lever API Docs:

Candidates can be applied to multiple job postings, meaning that candidates can have multiple applications. A candidate or contact may have multiple applications, each of which will be on a unique Opportunity. An Opportunity will have no more than one Application.

However, when reviewing our test data, we occasionally see multiple applications associated with a single opportunity. Given this discrepancy and the uncertainty around whether our test data can be trusted as a source of truth, we will maintain the current state of the tests for now.

We'll keep this ticket open for input from anyone with additional insights!

@fivetran-catfritz fivetran-catfritz added type:wontfix This will not be worked on and removed type:bug Something is broken or incorrect labels Oct 29, 2024
@fivetran-catfritz fivetran-catfritz changed the title [Bug] Update tests or models for multiple application_id records for a given opportunity_id [Discussion] Update tests or models for multiple application_id records for a given opportunity_id Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant