diff --git a/.github/workflows/add-2nd-reviewer.yml b/.github/workflows/add-2nd-reviewer.yml new file mode 100644 index 0000000..3f056aa --- /dev/null +++ b/.github/workflows/add-2nd-reviewer.yml @@ -0,0 +1,10 @@ +name: '2nd reviewer' +on: + pull_request_review: + types: [submitted] + +jobs: + auto_assign_reviewer: + if: github.event.review.state == 'approved' + uses: fivetran/dbt_package_automations/.github/workflows/add-2nd-reviewer.yml@main + secrets: inherit \ No newline at end of file diff --git a/.github/workflows/auto-release.yml b/.github/workflows/auto-release.yml new file mode 100644 index 0000000..8ed5853 --- /dev/null +++ b/.github/workflows/auto-release.yml @@ -0,0 +1,13 @@ +name: 'auto release' +on: + pull_request: + types: + - closed + branches: + - main + +jobs: + call-workflow-passing-data: + if: github.event.pull_request.merged + uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main + secrets: inherit \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 1294587..3415dbc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +# dbt_facebook_ads v0.7.1 + +[PR #36](https://github.com/fivetran/dbt_facebook_ads/pull/36) includes the following updates: +## Documentation Updates +- The [prerequisite steps in the README](https://github.com/fivetran/dbt_facebook_ads#step-1-prerequisites) for generating the `basic_ad` pre-built report have been modified to reflect the current state of the Facebook Ads connector. +- Adds the [DECISIONLOG](DECISIONLOG.md) to clarify why there exist differences among aggregations across different grains. + # dbt_facebook_ads v0.7.0 [PR #34](https://github.com/fivetran/dbt_facebook_ads/pull/34) includes the following updates: ## Feature update 🎉 diff --git a/DECISIONLOG.md b/DECISIONLOG.md index 4919de4..cd48274 100644 --- a/DECISIONLOG.md +++ b/DECISIONLOG.md @@ -15,4 +15,9 @@ Currently, your UTM report will only include: For source history tables that provide a `updated_at` field, the most recent record in the respective history tables are calculated using `updated_at`; otherwise, we use `_fivetran_synced` as a proxy field to calculate the most recent record. ## Passing Through Metrics Not Available -Please note that additional pass through metrics are only available for the source models as additional metrics such as `cpc`, `cpm` and `ctr` are already aggregated metrics that should not be rolled up into higher levels of reporting. \ No newline at end of file +Please note that additional pass through metrics are only available for the source models as additional metrics such as `cpc`, `cpm` and `ctr` are already aggregated metrics that should not be rolled up into higher levels of reporting. + +## Why don't metrics add up across different grains (Ex. ad level vs campaign level)? +Not all ads are served at the ad level. In other words, there are some ads that are served only at the ad group, campaign, etc. levels. The implications are that since not ads are included in the ad-level report, their associated spend, for example, won't be included at that grain. Therefore your spend totals may differ across the ad grain and another grain. + +This is a reason why we have broken out the ad reporting packages into separate hierarchical end models (Ad, Ad Group, Campaign, and more). Because if we only used ad-level reports, we could be missing data. \ No newline at end of file diff --git a/README.md b/README.md index 9b74ae3..4560c36 100644 --- a/README.md +++ b/README.md @@ -41,14 +41,10 @@ To use this dbt package, you must have the following: - At least one Fivetran Facebook Ads connector syncing data into your destination. - A **BigQuery**, **Snowflake**, **Redshift**, **PostgreSQL**, or **Databricks** destination. -- You will need to configure your Facebook Ads connector to pull the `BASIC_AD` pre-built report. Follow the below steps in the Fivetran UI to do so: - 1. Navigate to the connector setup form (**Setup** -> **Edit connection details** for pre-existing connectors) - 2. Click **Add table** - 3. Select **Pre-built Report** - 4. Set the table name to `basic_ad` - 5. Select `BASIC_AD` as the corresponding pre-built report - 6. Select a daily aggregation period - 7. Click **Ok** and **Save & test**! +- You will need to configure your Facebook Ads connector to pull the `basic_ad` pre-built report. This pre-built report should be enabled in your connector by default. However, to confirm this pre-built report is actively syncing you may perform the following steps: + 1. Navigate to the connector schema tab. + 2. Search for `basic_ad` and confirm it is selected. + 3. If not selected, do so and sync. If already selected you are ready to run the models! ### Databricks Dispatch Configuration If you are using a Databricks destination with this package you will need to add the below (or a variation of the below) dispatch configuration within your `dbt_project.yml`. This is required in order for the package to accurately search for macros within the `dbt-labs/spark_utils` then the `dbt-labs/dbt_utils` packages respectively. diff --git a/dbt_project.yml b/dbt_project.yml index 676d26a..f3ebd6b 100644 --- a/dbt_project.yml +++ b/dbt_project.yml @@ -1,5 +1,5 @@ name: 'facebook_ads' -version: '0.7.0' +version: '0.7.1' config-version: 2 require-dbt-version: [">=1.3.0", "<2.0.0"] models: diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml index 2326621..57214cc 100644 --- a/integration_tests/dbt_project.yml +++ b/integration_tests/dbt_project.yml @@ -1,5 +1,5 @@ name: 'facebook_ads_integration_tests' -version: '0.7.0' +version: '0.7.1' profile: 'integration_tests' config-version: 2 diff --git a/integration_tests/requirements.txt b/integration_tests/requirements.txt index ca5a642..e615720 100644 --- a/integration_tests/requirements.txt +++ b/integration_tests/requirements.txt @@ -4,6 +4,4 @@ dbt-redshift>=1.3.0,<2.0.0 dbt-postgres>=1.3.0,<2.0.0 dbt-spark>=1.3.0,<2.0.0 dbt-spark[PyHive]>=1.3.0,<2.0.0 -dbt-databricks>=1.3.0,<2.0.0 - -oscrypto @ git+https://github.com/wbond/oscrypto.git@d5f3437 +dbt-databricks>=1.6.0,<2.0.0