Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve expression type parsing #49

Closed
erwinvaneyk opened this issue Sep 20, 2017 · 2 comments
Closed

Improve expression type parsing #49

erwinvaneyk opened this issue Sep 20, 2017 · 2 comments

Comments

@erwinvaneyk
Copy link
Member

Currently implicit expressions are recognized only when there is a trailing $. This lacks flexibility in the expressions. There should be ways to improve this identification of expression types vs. regular strings.

@erwinvaneyk
Copy link
Member Author

Current proposed solution (credits @soamvasani) is to use "{...}" to mark a string as an expression. It 'abuses' the fact that in javascript {<expr>} == <expr> to avoid the need to parse the expression before feeding it to Otto.

@erwinvaneyk
Copy link
Member Author

erwinvaneyk commented Nov 24, 2017

Fixed. Current solution is a {<expr>} syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant