Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TypedValue serialization from json format #39

Closed
erwinvaneyk opened this issue Sep 17, 2017 · 1 comment
Closed

Remove TypedValue serialization from json format #39

erwinvaneyk opened this issue Sep 17, 2017 · 1 comment

Comments

@erwinvaneyk
Copy link
Member

Currently the JSON workflow definition representation is a direct translation from the internal protobuf workflow spec. Due to the limitations of Protobuf, TypedValues cannot be represented as arbitrary types in the JSON format, which leads to unreadable serialized values (see github.com/fission/fission-workflow/tree/master/examples/whales/maybewhale.wf.json)

We should separate the JSON format from the internal Protobuf data structure to ensure that the inputs remain readable to the user.
@erwinvaneyk
Copy link
Member Author

No longer relevant as we removed the JSON from the user's set of concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwinvaneyk