Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluation queue implementation #148

Closed
erwinvaneyk opened this issue Jun 6, 2018 · 2 comments
Closed

Fix evaluation queue implementation #148

erwinvaneyk opened this issue Jun 6, 2018 · 2 comments

Comments

@erwinvaneyk
Copy link
Member

Currently, there is a initial, simple implementation of a queue to feed the controller workflow invocation that it should evaluate. However with higher loads of workflow invocations the queue tends to overflow. This is due to two reasons:

  • Invocations can occur multiple times in the queue
  • There is no notion of priority
    These issues cause the controller not to keep up with the growing queue. Besides, the invocations that need to be evaluated get buried in between the unnecessary invocations.

To resolve this we need an implementation that supports both priorities and ensure that there are no duplicates in the queue. A promising solution to this is to use a priority queue.

@ghost
Copy link

ghost commented Sep 15, 2018

#167 should also close this issue, right?

@erwinvaneyk
Copy link
Member Author

Yes thanks @thenamly 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant