Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hooks in configs not running (#984) #985

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 7, 2018

Hooks were not getting attached to parsed nodes during the parsing stage of compilation, because the not-fully-built node dict was getting passed into hooks.get_hooks.

Instead, pass the parsed node in, and change hooks.get_hooks to expect a ParsedNode.

I also added tests for this behavior, of course.

@beckjake beckjake requested a review from cmcarthur September 7, 2018 17:39
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. approved

@beckjake beckjake merged commit be54123 into dev/lucretia-mott Sep 7, 2018
@beckjake beckjake deleted the fix/hooks-in-configs-not-running branch September 7, 2018 19:50
@beckjake beckjake restored the fix/hooks-in-configs-not-running branch September 7, 2018 19:51
@beckjake beckjake deleted the fix/hooks-in-configs-not-running branch September 7, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants