-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to minimal-snowplow-tracker #848
Conversation
requirements.txt
Outdated
@@ -5,7 +5,7 @@ PyYAML>=3.11 | |||
psycopg2==2.7.5 | |||
sqlparse==0.2.3 | |||
networkx==1.11 | |||
snowplow-tracker==0.7.2 | |||
minimal-snowplow-tracker==0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove other pinned dependencies because of snowplow-tracker (esp celery)
update setup.py, too
requirements.txt
Outdated
@@ -5,7 +5,7 @@ PyYAML>=3.11 | |||
psycopg2==2.7.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=2.7.5, <2.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove pytz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly remove argparse?
setup.py
Outdated
'sqlparse==0.2.3', | ||
'networkx==1.11', | ||
'snowplow-tracker==0.7.2', | ||
'celery==3.1.23', | ||
'minimal-snowplow-tracker==0.0.1', | ||
'snowflake-connector-python>=1.4.9', | ||
'requests>=2.18.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be >=2.18.0,<3
- requests is very good about semver but that means any 3.0
will be pretty much guaranteed to break something...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one comment about requests but I don't think it's a big deal.
No description provided.