-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix snowflake seed types, add chunking for seed files with more than 16k rows #694
Conversation
Fix for #690 |
",\n".join(placeholders))) | ||
|
||
cls.add_query(profile, sql, | ||
bindings=bindings, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmcarthur is this correct? It seems to me that the second chunk would get the bindings from the first chunk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bindings is reset inside the outer loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT @cmcarthur
let's get this working in development, then revisit the float8
decision :)
This fixes two things: