Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for null output for tests defined in ephemeral dir [development] #509

Merged
merged 3 commits into from
Aug 22, 2017

Conversation

drewbanin
Copy link
Contributor

Previously, schema.yml files defined in models configured with materialized: ephemeral were effectively ignored by the dbt runner. dbt did not distinguish between ephemeral models and tests.
While it's a little strange that tests even have a materialized config, they are "resources" and adhere to the same contract as models. This branch fixes #501

Before:

Found 3 models, 1 tests, 0 archives, 0 analyses, 30 macros, 0 operations

14:32:34 | Concurrency: 1 threads (target='dev')
14:32:34 |

Completed successfully

Done. PASS=2 ERROR=0 SKIP=0 TOTAL=2

After:

Found 3 models, 1 tests, 0 archives, 0 analyses, 30 macros, 0 operations

14:32:34 | Concurrency: 1 threads (target='dev')
14:32:34 |
14:32:34 | 1 of 1 START test unique_events_generate_series...................... [RUN]
14:32:37 | 1 of 1 PASS unique_events_generate_series............................ [PASS in 3.18s]

Completed successfully

Done. PASS=1 ERROR=0 SKIP=0 TOTAL=1

@drewbanin drewbanin requested a review from cmcarthur August 16, 2017 18:37
@drewbanin drewbanin modified the milestone: 0.9.0 rc-1 Aug 17, 2017
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drewbanin looks good to me

@drewbanin drewbanin merged commit b72854d into development Aug 22, 2017
@drewbanin drewbanin deleted the fix/tests-cant-be-ephemeral branch August 22, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants