colorized dbt output #441
Merged
colorized dbt output #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
requested changes
May 23, 2017
dbt/config.py
Outdated
|
|
||
| return True | ||
| def send_anonymous_usage_stats(config): | ||
| return config.get('send_anonymous_usage_stats', True) |
There was a problem hiding this comment.
@drewbanin I'm not sure this works. There are some unit test failures in circle & appveyor
dbt/runner.py
Outdated
| @@ -19,15 +17,17 @@ | |||
| import dbt.schema | |||
| import dbt.graph.selector | |||
| import dbt.model | |||
| import dbt.printer as printer | |||
There was a problem hiding this comment.
can you change this file to use the globally qualified name?
dbt/printer.py
Outdated
| stats_line = "Done. PASS={pass} ERROR={error} SKIP={skip} TOTAL={total}" | ||
| stats_line = stats_line.format(**stats) | ||
|
|
||
| return "{}\n{}".format(message, stats_line) |
There was a problem hiding this comment.
love that all this got pulled out of runner
dbt/printer.py
Outdated
|
|
||
| def color(text, color_code): | ||
| if USE_COLORS: | ||
| return "{}{}{}".format(color_code, text, colorama.Style.RESET_ALL) |
There was a problem hiding this comment.
@drewbanin is it possible to create an enumeration of available colors here, like:
RED_FOREGROUND = colorama.Fore.RED
GREEN_FOREGROUND = colorama.Fore.GREEN
YELLOW_FOREGROUND = colorama.Fore.YELLOW
...
and then reference those constants directly?
I'm thinking that would make it easy to override the colors when using dbt as a library
cmcarthur
approved these changes
May 23, 2017
|
|
!!
|
fixes #357 |
9 tasks
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
colorize dbt output automatic commit by git-black, original commits: dfb24fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: