Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dependencies more compact #342

Merged
merged 4 commits into from
Mar 20, 2017
Merged

make dependencies more compact #342

merged 4 commits into from
Mar 20, 2017

Conversation

cmcarthur
Copy link
Member

Tested with:

  • starting from blank project, dbt deps
  • run dbt deps again on same commit
  • go into dependency, pull history with git fetch --depth 20 origin master
  • checkout an old commit
  • run dbt deps again, see that it updated to the latest commit
  • remove the dependency from dbt_modules, manually check it out to a branch, then run dbt deps. it checks out to the branch in dbt_project with depth 1

I was not able to test that a new commit on the current branch works, but I feel confident that the branch-switching test proves that it will work.

@cmcarthur
Copy link
Member Author

Fix for #277

@cmcarthur cmcarthur requested a review from drewbanin March 20, 2017 14:28
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome! Make sure to update the changelog, otherwise #approved

@cmcarthur cmcarthur merged commit 4f79c28 into development Mar 20, 2017
@cmcarthur cmcarthur deleted the compact-deps branch March 20, 2017 17:51
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
automatic commit by git-black, original commits:
  4f79c28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants