Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change analyst-collective to fishtown-analytics #300

Merged
merged 2 commits into from
Feb 27, 2017

Conversation

drewbanin
Copy link
Contributor

s/analyst-collective/fishtown-analytics/g

@drewbanin drewbanin added the user docs [docs.getdbt.com] Needs better documentation label Feb 27, 2017
@drewbanin drewbanin added this to the Documentation + Usability milestone Feb 27, 2017
Copy link
Member

@jthandy jthandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than these two comments

@@ -2,7 +2,7 @@

> In 2015-2016, a team of folks at RJMetrics had the opportunity to observe, and participate in, a significant evolution of the analytics ecosystem. The seeds of dbt were conceived in this environment, and the viewpoint below was written to reflect what we had learned and how we believed the world should be different. **dbt is our attempt to address the workflow challenges we observed, and as such, this viewpoint is the most foundational statement of the dbt project's goals.**

> The remainder of this document is largely unedited from [the original post](https://medium.com/analyst-collective/building-a-mature-analytics-workflow-the-analyst-collective-viewpoint-7653473ef05b).
> The remainder of this document is largely unedited from [the original post](https://medium.com/fishtown-analytics/building-a-mature-analytics-workflow-the-fishtown-analytics-viewpoint-7653473ef05b).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't resolve

dbt/task/init.py Outdated
@@ -25,8 +25,8 @@

# uncomment below and add real repositories to add dependencies to this project
#repositories:
# - "[email protected]:analyst-collective/repo-name-1"
# - "[email protected]:analyst-collective/repo-name-2"
# - "[email protected]:fishtown-analytics/repo-name-1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just make this [your_org]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually though about that for a second... figured the use case was more fishtown-analytics/snowplow than your-org/your-package. But sure, np

@drewbanin
Copy link
Contributor Author

@jthandy addressed!

@drewbanin drewbanin removed the request for review from cmcarthur February 27, 2017 15:39
@drewbanin drewbanin merged commit fcf5e63 into development Feb 27, 2017
@drewbanin drewbanin deleted the fishtown-docalytics branch February 27, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants